Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mar3hc/add robot selftest to pipeline #325

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

trimai3001
Copy link
Collaborator

No description provided.

Copy link
Owner

@test-fullautomation test-fullautomation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tri,
please consider my question.
Thank you,
Thomas

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tri,

it's good to include the robotframework-selftest/testcases repository in our pipeline.
My concern is that e.g. qconnect-tests will need a server. Did you consider this?

Thank you,
Thomas

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Thomas,

As discussed with Mr. Ngoan, he has already implemented the server startup process before running the qconnect-test in the pull request: https://github.com/test-fullautomation/robotframework-selftest/pull/1/files#diff-2613b359e23de64ceb5f9dc31c4fbab4057a597da40df6b88d85d12edf330c73. However, the implementation might be outdated. I'll review Ngoan's file and update it as needed, then commit the new version to the self-test repository.

@test-fullautomation test-fullautomation added 0.13.0 enhancement New feature or request labels Jul 31, 2024
@test-fullautomation test-fullautomation added this to the 0.13.0 milestone Jul 31, 2024
@test-fullautomation
Copy link
Owner

Hi @trimai3001 ,
very good!
We also need to assure that only tests will be activated which need no physical device. Consider this please, too.
Thank you,l
Thomas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.13.0 enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants