-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a unified index size for state machines. #78
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
… state machine. Slightly less size-efficient in certain cases, but will significantly cut down the thousands of generic instantiations that bloat the NativeAOT executables.
teo-tsirpanis
force-pushed
the
state-machine-index-size
branch
from
October 13, 2024 09:22
a46fb0d
to
67ea0cb
Compare
Quality Gate passedIssues Measures |
|
Benchmark reportGrammarReaderBenchmark
|
Superseded by #305. The performance differences are tiny (also ran the JSON benchmarks), but the grammar file size regression was significant, and the existing format is better by itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State machines contain indices to many different things (states, edges, actions, tables…). For maximum size efficiency each of these indices can be compressed to a size of one, two or four bytes.
The problem with each index having its own size is that it results in thousands of generic type instantiations, because we specialize the state machine classes based on the type of each index. This results in huge NativeAOT binaries.
This PR changes the specification to have a single index size per state machine. It will be less size-efficient -if a DFA has say 100 states and 1000 edges in total, now indices to both states and edges will have a size of two bytes-, but the number of instantiations will be small. For comparison a sample console app that converts GOLD Parser grammars weighs 20MB before this change, after this it drops to 3.
Let's not merge it immediately, I want to also investigate forgoing generic descendants of classes, in favor of switching on the index size every time, as we do with grammar tables.