Update the tokenizer composability model. #281
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While porting the samples to FarkleNeo, it was discovered that the existing tokenizer extensibility model was not adequate to implement the indent-based grammar. This PR makes the following changes:
true
.false
instead of continuing until they encounter a terminal.ParserInputReader<TChar>
was added to check for it.false
, the parser must still exit and return with more available input.The new design was validated locally by successfully running the indent-based grammar checks.