Builder API — LALR, predefined terminals #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… state in its own array. It will be slightly less efficient as there will be more than one allocations, but it's quite easier to work with.
…d productions. This will simplify emitting it from the builder and improve performance.
Figuring out a place to put reporting conflicts was hard, with the candidates of doing it at the time of resolving the conflicts or at the time of writing them to the grammar getting rejected for various reasons. Instead we will do it later, after the grammar gets created by enumerating the conflicts from the grammar's data.
And add various utilities.
This means merging duplicates while considering the grammar's case sensitivity.
Now all tests pass.
Instead of comparing between a grammar file and a Farkle grammar, we recreate the syntax from the grammar file, and compare the LR state machine we built to the one GOLD Parser built.
Very likely an overkill, and causes SonarCloud warnings. If there's something wrong there, it will be caught in other tests either way.
teo-tsirpanis
force-pushed
the
builder-lalr
branch
from
0bd7ab1
to
5b46f5f
Compare
And test Rename's behavior.
And add a test that all string resources are valid format strings. It wouldn't catch these typos but it's good to have.
It must always be the end symbol only.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.