-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the tkn reference to the CLI docs #206
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bd2b411
to
fa90184
Compare
Should the 'What's Next?' link on the main CLI page link to these docs instead of the GitHub repo? Update: Also is this new section expected?
It seems like they're both essentially trying to link to the same content, so probably only need to keep one of them. |
Yeah, good point, that's hosted on tektoncd/cli, so we could change it there
Yeah, this new section is added as part of this PR, it contains the
|
thanks for doing this, What do we need to change in our docs so we can get something like "TektonCD CLI" instead of |
That's configured here: https://github.com/tektoncd/website/pull/206/files#diff-d25f162c4c374d7c8bbdf20d08628221b8bc1ea74e4cb02a12986acf01d68159R47 I will amend the configuration in this PR in a moment. |
Add the doc/cmd folder to add the tkn reference docs to the CLI documentation. Add support for defaulting page title and link title to the filename, if not set, which works OK for tkn. Fixes tektoncd#118 Signed-off-by: Andrea Frittoli <[email protected]>
fa90184
to
0909360
Compare
cool thank you! |
@afrittoli: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
@tekton-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
Add the doc/cmd folder to add the tkn reference docs to the CLI
documentation. Add support for defaulting page title and link
title to the filename, if not set, which works OK for tkn.
Fixes #118
Signed-off-by: Andrea Frittoli [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
/kind documentation