-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add disable_spire build tag for entrypoint command #8548
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following is the coverage report on the affected files.
|
294dcf8
to
e6535ed
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
This comment will close the issue once this PR is merged, but it only addresses one part of the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this.
I think it needs some documentation:
- dev docs explaining how to build with spire disabled
- end user docs, in the spire section, explaining tha spire needs to be enabled at build time for the config flag to actually work
Would it make sense to log something or fail if the spire flag was enabled when using a build without spire?
e6535ed
to
2a4dc09
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
2a4dc09
to
7d894e1
Compare
@afrittoli @vdemeester I have added docs and check enable_spire flag to exit if the build is not spire enabled |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/kind cleanup |
We need to make Tekton Pipelines FIPS compliant, and the entrypoint command is a key step in this effort. Since it is statically compiled, we must ensure that cryptographic symbols are removed from the entrypoint binary. To achieve this, we need compile options to disable TLS, SPIRE, and any network-related functionality.
This PR is a partial implementation that introduces a build tag to disable SPIRE (github.com/tektoncd/pipeline/pkg/spire) in cmd/entrypoint/main.go.
Changes
This PR introduces a build tag to conditionally disable SPIRE functionality in the cmd/entrypoint/main.go file. The following changes have been made:
spire.go for when SPIRE is enabled.
spire_disabled.go for when SPIRE is disabled using the disable_spire build tag.
partially fixes #8531
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes