Change to FQCN with ansible-lint fixer #553
Conversation
|
I think this only makes sense if a CI test is also added to ensure that automatic formatting is always applied in future. We do this with Black for Python, for example. A test runs in the CI that executes Black and if it makes changes, the test fails. |
According to already defined CI jobs, it will execute pre-commit run which includes ansible-lint test that will fail if something isn't according to configured standard. So already in place |
|
Hey, thank you! Sounds good! I want to get a few PRs merge in first, which might break your PR but you should be able to fix it easily with |
|
@rholmboe sorry about the wait but I wanted merge the other PRs before this since this PR has a lot of style changes. |
No worries, let me know when I can resolve conflicts and upload a new patch. |
All pending PRs merged. I think you can do a rebase & resolve conflicts. |
Since ansible-base 2.10 (later ansible-core), FQCN is the new way to go. Updated .ansible-lint with a production profile and removed fqcn in skip_list. Updated .yamllint with rules needed. Ran ansible-lint --fix=all, then manually applied some minor changes.
rholmboe
force-pushed
the
feature/change-to-fqcn-with-linter
branch
from
48f5096
to
6ed5868
Compare
|
PR updated, ready for review |
|
@rholmboe it seems like the build is failing. |
Yup, applied fix. yamllint failed on octal, something ansible-lint have in ignore. |
|
Thank you! |
|
@timothystewart6 no worries man, thank you for creating this and making life easier for the rest of us! |
Proposed Changes
Since ansible-base 2.10 (later ansible-core), FQCN is the new way to go.
Updated .ansible-lint with a production profile and removed fqcn in skip_list. Updated .yamllint with rules needed.
Ran ansible-lint --fix=all, then manually applied some minor changes.
Checklist
site.ymlplaybookreset.ymlplaybook