fix: not found subscribe throw null

teableio · Sep 19, 2024 · 50f2e1b · 50f2e1b
1 parent 3648597
commit 50f2e1b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/apps/nestjs-backend/src/features/comment/comment-open-api.service.ts b/apps/nestjs-backend/src/features/comment/comment-open-api.service.ts
@@ -298,7 +298,7 @@ export class CommentOpenApiService {
 
   async getSubscribeDetail(tableId: string, recordId: string) {
     return await this.prismaService.commentSubscription
-      .findUnique({
+      .findUniqueOrThrow({
         where: {
           // eslint-disable-next-line
           tableId_recordId: {

diff --git a/apps/nestjs-backend/test/comment.e2e-spec.ts b/apps/nestjs-backend/test/comment.e2e-spec.ts
@@ -182,6 +182,7 @@ describe('OpenAPI CommentController (e2e)', () => {
 
       await deleteCommentSubscribe(tableId, recordId);
       const subscribeInfo = await getCommentSubscribe(tableId, recordId);
+      // actually the subscribe info is null but, there is no idea to return ''.
       expect(subscribeInfo.data).toEqual('');
     });
   });

diff --git a/packages/openapi/src/comment/subscribe/get-subscribe.ts b/packages/openapi/src/comment/subscribe/get-subscribe.ts
@@ -26,6 +26,11 @@ export const GetCommentSubscribeRoute: RouteConfig = registerRoute({
   responses: {
     200: {
       description: 'Successfully get record comment subscribe detail.',
+      content: {
+        'application/json': {
+          schema: commentSubscribeVoSchema.nullable(),
+        },
+      },
     },
   },
   tags: ['comment'],