Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use Object.getPrototypeOf to get prototype in __proto__-fn-name.js #4205

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

aapoalas
Copy link
Contributor

@aapoalas aapoalas commented Aug 21, 2024

As best as I can tell, this test is accidentally and very confusingly relying on the Annex B __proto__ getter when testing the spec-defined __proto__ key literal special case.

As an example: Node.js passes this test as it is currently, but Deno does not as Deno does not implement the __proto__ getters and setters.

@aapoalas aapoalas requested a review from a team as a code owner August 21, 2024 18:28
@aapoalas aapoalas changed the title fix: Use Object.getPrototypeOf to get prototype in __proto__-fn-name.js fix: Use Object.getPrototypeOf to get prototype in __proto__-fn-name.js Aug 21, 2024
@ljharb ljharb requested a review from a team August 21, 2024 19:24
@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 22, 2024

Please replace the es6id by the relevant esid

@aapoalas
Copy link
Contributor Author

aapoalas commented Aug 22, 2024

Please replace the es6id by the relevant esid

According to some documentation I found it's a deprecated: Should I update it or just remove it?

Also should I update the spec text quote?

@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 22, 2024

Replace by the key esid

@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 22, 2024

And yes, if the quoted spec text changed, please fix that too.

@aapoalas
Copy link
Contributor Author

aapoalas commented Sep 7, 2024

Replace by the key esid
And yes, if the quoted spec text changed, please fix that too.

Oops, sorry this slipped my mind somehow. I've now fixed the esid to point to PropertyDefinitionEvaluation as it should, and copied over the relevant steps from the spec text.

Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Ms2ger Ms2ger merged commit cff5a60 into tc39:main Sep 9, 2024
8 checks passed
@aapoalas aapoalas deleted the fix/proto-fn-name branch September 9, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants