-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use Object.getPrototypeOf to get prototype in __proto__-fn-name.js
#4205
Conversation
__proto__-fn-name.js
Please replace the es6id by the relevant esid |
According to some documentation I found it's a deprecated: Should I update it or just remove it? Also should I update the spec text quote? |
Replace by the key |
And yes, if the quoted spec text changed, please fix that too. |
Oops, sorry this slipped my mind somehow. I've now fixed the esid to point to PropertyDefinitionEvaluation as it should, and copied over the relevant steps from the spec text. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
As best as I can tell, this test is accidentally and very confusingly relying on the Annex B
__proto__
getter when testing the spec-defined__proto__
key literal special case.As an example: Node.js passes this test as it is currently, but Deno does not as Deno does not implement the
__proto__
getters and setters.