🏗️✨ introduce the Nu Html Checker (v.Nu) #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerekNonGeneric
force-pushed
the
feat/add-html-validator
branch
8 times, most recently
from
a6ec72e to
5d71128
Compare
DerekNonGeneric
force-pushed
the
feat/add-html-validator
branch
2 times, most recently
from
12b65d2 to
6401cbf
Compare
DerekNonGeneric
commented
Oct 10, 2020
DerekNonGeneric
changed the title
DerekNonGeneric
changed the title
|
In the future, you don't need to make every modification a separate commit. It is clear enough to have one commit be adding the tool, and the second commit be the changes recommended by the tool. |
DerekNonGeneric
force-pushed
the
feat/add-html-validator
branch
2 times, most recently
from
c272242 to
6c1e3f8
Compare
Sounds good, I was just concerned that it would be difficult to review. Apologies. |
DerekNonGeneric
force-pushed
the
feat/add-html-validator
branch
from
6c1e3f8 to
609033a
Compare
DerekNonGeneric
added a commit
to DerekNonGeneric/tc39.github.io
that referenced
this pull request
Nov 6, 2020
* 🏗️✨ add check-html task * 🔧 error: End tag “br”. * 🔧 error: Mising closing tags. * 🔧 error: Stray end tag “div”. * 🔧 error: Stray end tag “section”. * 🔧 error: Element “z” not allowed as child of element “code” here. * 🔧 warning: The “type” attribute is unnecessary. * 🔧 warning: The “region” role is unnecessary. * 🔧 warning: Section lacks heading. * 🔧 error: Element “div” is missing “role” attribute. * 🔧 error: Attribute “aria-selected” not allowed on “div” here. * 🔧 error: Illegal character in query: “|” is not allowed. * 📦 add runtime dependencies to container * 🏗️ incorporate check-html task into CI * 🔧 error: End tag “div” seen, but there were open elements. * 🔧 error: Unclosed element “nav”.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To validate HTML, this PR introduces the Nu Html Checker (v.Nu) in an independent task.
It corrects
all[most of the] warnings and [all of the] errors flagged by it.This is another step in working towards the goal of keeping the site up-to-date.