clarify iterator lists #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
force-pushed
the
open-iters
branch
from
bc3c980 to
44e387c
Compare
|
Nice, done. |
michaelficarra
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revisiting this I found some parts confusing, so I've tweaked it a bit to clarify.
The
Assert: _openIters_ is not empty.step won't be true until after #20 lands.An alternative to replacing elements of
_iters_withnulland tracking_openIters_as separate list could be to just rely on the[[Done]]field of Iterator Records. That would require updating IteratorCloseAll to filter out the[[Done]]: trueones, though.