Remove trailing zeroes #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessealama
force-pushed
the
remove-trailing-zeroes
branch
from
fe2f84e
to
3481c4d
Compare
Co-authored-by: Nicolò Ribaudo <[email protected]>
Co-authored-by: Nicolò Ribaudo <[email protected]>
And propagate that change throughout. As we are working with canonicalized decimal values, which are essentially just a special kind of mathematical value, we can remove a lot of the special handling and destructuring that we previously did.
This is unnecessary because all we care avbout is finite decimal representability. When computing *the* exponent of a number, we wil choose the minimum power that yields an integer, in which case the fact that any smaller power yields a non-integer is understood.
nicolo-ribaudo
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove support for trailing zeroes. This involves removing all discussion of cohorts and quanta, thereby considerably simplifying the data model.