Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emu-format --check with multiple files #607

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

ptomato
Copy link
Contributor

@ptomato ptomato commented Sep 12, 2024

Previously, running emu-format --check with multiple files would only check the first file. Fix the CLI arguments processing logic so that the only special case for a list of one file is when it needs to be printed to stdout. Move checking into the loop through the file list, as is done with writing.

Closes: #606

Previously, running emu-format --check with multiple files would only
check the first file. Fix the CLI arguments processing logic so that the
only special case for a list of one file is when it needs to be printed
to stdout. Move checking into the loop through the file list, as is done
with writing.

Closes: tc39#606
Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bakkot bakkot merged commit f9f05bf into tc39:main Sep 12, 2024
2 checks passed
@ptomato ptomato deleted the 606-emu-format-check branch September 12, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

emu-format --check only checks the first file on the command line
2 participants