-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: Store ToString(𝔽(k)) in a variable for consistency #3531
Conversation
I don't like doing this in places where the alias would only be referred to once. I am okay with |
01df6e8
to
ae16f29
Compare
Thank you! |
ae16f29
to
b2107f8
Compare
Related: b1c00ce |
Would it be better to upgrade the version? |
b2107f8
to
cbc6187
Compare
@yossydev would you please register as a contributor? |
cbc6187
to
f2b9485
Compare
f2b9485
to
0f3de74
Compare
@ljharb |
ToString(𝔽(k)) was sometimes stored in let Pk and sometimes not. While this does not affect behavior, for consistency in the specification, I have standardized it to be stored in a variable.
Fixes #3530