Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project isn't dead! bitmath 2.0.0 coming soon! #99

Open
tbielawa opened this issue Jan 28, 2023 · 5 comments
Open

Project isn't dead! bitmath 2.0.0 coming soon! #99

tbielawa opened this issue Jan 28, 2023 · 5 comments
Assignees
Milestone

Comments

@tbielawa
Copy link
Owner

2.0.0 is coming and it will be python 3 only. Keep up with progress on this branch as I work up to the release.

Watch the news file for specifics. master...2023-01-26-no-more-py2#diff-61d113525e9cc93565799a4bb8b34a68e2945b8a3f7d90c81380614a4ea39542R25

PR's welcome. Existing PR's will get reviewed to see how they fit into the future direction of the project.

@tbielawa tbielawa self-assigned this Jan 28, 2023
@tbielawa tbielawa added this to the 2.0.0 milestone Jan 28, 2023
@tbielawa
Copy link
Owner Author

tbielawa commented Feb 6, 2023

Docs are building on read the docs now: https://bitmath.readthedocs.io/en/2023-01-26-no-more-py2/index.html

@FelixSchwarz
Copy link

This is great to hear. One thing I was recently confused about is parse_string_unsafe: "unsafe" means to me that should not use this on untrusted inputs (security) but it seems the function just uses some heuristics/there is some ambiguity. It would be nice if the name reflects that in 2.0. Using an "unsafe" function will be flagged in every code review and will cause the reviewer to dig into the implementation to verify that this is really "safe" to use.

@tbielawa
Copy link
Owner Author

This is great to hear. One thing I was recently confused about is parse_string_unsafe: "unsafe" means to me that should not use this on untrusted inputs (security) but it seems the function just uses some heuristics/there is some ambiguity. It would be nice if the name reflects that in 2.0. Using an "unsafe" function will be flagged in every code review and will cause the reviewer to dig into the implementation to verify that this is really "safe" to use.

That's a very smart idea. I'll add that to the list

@tbielawa
Copy link
Owner Author

This is great to hear. One thing I was recently confused about is parse_string_unsafe: "unsafe" means to me that should not use this on untrusted inputs (security) but it seems the function just uses some heuristics/there is some ambiguity. It would be nice if the name reflects that in 2.0. Using an "unsafe" function will be flagged in every code review and will cause the reviewer to dig into the implementation to verify that this is really "safe" to use.

Can I have your thoughts on this?

#101

@tbielawa tbielawa pinned this issue Feb 15, 2023
@tbielawa
Copy link
Owner Author

tbielawa commented Jun 2, 2024

Thanks for your patience everyone. 2023 was especially busy for me and I am just now getting settled into a place where I can get back to work here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants