You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the 2.0 update bug #99, it was brought up that parse_string_unsafe can have negative side effects
Using an "unsafe" function will be flagged in every code review and will cause the reviewer to dig into the implementation to verify that this is really "safe" to use
Get rid of the _unsafe / _liberally functions completely and add a kwarg to the standard parse_string function which allows it to apply the less strict parsing logic.
I never saw "liberally" in an API. Personally I sometimes use "guess_...". However I like something like a strict=True/False parameter even more. The default would be strict parsing but users could use a more "liberal" one.
In the 2.0 update bug #99, it was brought up that
parse_string_unsafe
can have negative side effectsOriginally posted by @FelixSchwarz in #99 (comment)
I'm proposing
_liberally
because definition no. 2 when I looked it up is:which feels accurate for what it does.
Thoughts?
The text was updated successfully, but these errors were encountered: