-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upload assets to the release associated with given tagName #895
feat: upload assets to the release associated with given tagName #895
Conversation
I use minor version since It maintains forward compatibility. |
@FabianLars Friendly ping. Any comments for it? |
yeah sorry, i wanted to look at this for ages but there's always some bs coming in between 🙃 I hope i can give it a proper look on monday or tuesday (will be on vacation after that), but the thing i already noticed is that there's quite a lot of duplicate code now (the json upload stuff). The release checks&creation should be its own block. |
I got u. I will do some changes later |
3d08ab3
to
4102ca2
Compare
@FabianLars sorry for so many ci failures :) I believe it's working now.Do you have time to give it a proper look now? |
no worries, thanks for resolving them :) i'm working on another pr rn but will get to yours right after (today) |
while trying to refactor it a bit, similar to how create-release has its own function i noticed that create-release basically contains the same code so we can simplify this quite a bit by just making releaseName optional there too. Gonna push a commit in a few :) |
this way we also can use the existing draft lookup (not included in getReleaseByTag) |
…rget release After tauri-apps/tauri-action#895 . tauri-action support uploading the artifacts to the release associated with the given tagName
After tauri-apps/tauri-action#895 . tauri-action support uploading the artifacts to the release associated with the given tagName
Hey all, just a heads up. My app was building fine up until one of the last two releases of this. What happened?You can check out my releases here. Let me know if you guys need logs or more info or anything, I can help troubleshoot. |
Can you list out one of failed action(no latest.json) and one of success action? Maybe you can turn to latest issues. Tons of feedbacks there (: |
Enable uploading assets to the target release associated with the given tagName (if exist).
TL;DR
The basic motivation is that I'm using googleapis/release-please github action to release automatically. However, it only provides
tagName
as output if a release is created successfully. And we can use this rest api to get the corresponding releaseId by the given tagName. That's why I did it.Test Example
I've apply this action on my project here Chiichen/JinhsiStudio. This is the related action and the release. It seems to be working well
Let me know if it's an acceptable enhancement. And I will add some docs for it (README or somewhere else?)