Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add streamer refresh interval #212

Merged
merged 1 commit into from
Feb 5, 2025
Merged

add streamer refresh interval #212

merged 1 commit into from
Feb 5, 2025

Conversation

Graeme22
Copy link
Contributor

@Graeme22 Graeme22 commented Feb 5, 2025

Description

Previously, the "acceptAggregationPeriod" of DXLink channels was hardcoded to a value of 10, leading to unacceptably long delays between quotes in many scenarios. This fixes the problem by adding a new streamer parameter, refresh_interval, which allows each user to configure the value as desired. In addition, the default value is now 0.1, which is close to real-time, rather than the unwieldy 10, so most users will get immediate benefits without any changes.

Related issue(s)

Fixes #211

Pre-merge checklist

  • Code formatted correctly (check with make lint)
  • Code implemented for both sync and async
  • Passing tests locally (check with make test, make sure you have TT_USERNAME, TT_PASSWORD, and TT_ACCOUNT environment variables set)
  • New tests added (if applicable)

Please note that, in order to pass the tests, you'll need to set up your Tastytrade credentials as repository secrets on your local fork. Read more at CONTRIBUTING.md.

@Graeme22 Graeme22 merged commit a5788cf into master Feb 5, 2025
1 check failed
@Graeme22 Graeme22 deleted the refresh-interval branch February 5, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aggregationPeriod not configurable
1 participant