formatter: fix rendering of empty maps #1109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patapenka-alexey
force-pushed
the
patapenka-alexey/gh-1102-empty-table-crash
branch
2 times, most recently
from
d3aeeb9 to
e91b608
Compare
d-enk
reviewed
Feb 25, 2025
cli/formatter/table.go
Outdated
| itemMap.insert(strconv.Itoa(i+1), item[i]) | ||
| } else { | ||
| itemMap.insert(strconv.Itoa(i+1), "") | ||
| if maxLen > 0 { |
There was a problem hiding this comment.
Suggested change
| if maxLen > 0 { | |
| if maxLen == 0 { | |
| return "", nil | |
| } |
There was a problem hiding this comment.
Ooops. Thanks!
Comment on lines
+314
to
+322
| { | ||
| // when user typed to console: | ||
| // localhost:xxxx> \set output table | ||
| // localhost:xxxx> {} | ||
| formatter.TableFormat, | ||
| "{}", | ||
| "\n", | ||
| false, | ||
| }, |
There was a problem hiding this comment.
Please, add tests with {}, {}; {{}}; {{}, {}}
AlexandrLitkevich
approved these changes
Feb 25, 2025
patapenka-alexey
force-pushed
the
patapenka-alexey/gh-1102-empty-table-crash
branch
from
e91b608 to
b9767dd
Compare
patapenka-alexey
force-pushed
the
patapenka-alexey/gh-1102-empty-table-crash
branch
from
b9767dd to
f37087d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1102