aeon: add connection from the etcd/tcs #1108
Open
+599
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandrLitkevich
force-pushed
the
TNTP-1074
branch
4 times, most recently
from
46ee573 to
6c997fd
Compare
AlexandrLitkevich
force-pushed
the
TNTP-1074
branch
2 times, most recently
from
d9a0ee8 to
fdacd23
Compare
AlexandrLitkevich
requested review from
dmyger,
patapenka-alexey and
oleg-jukovec
|
|
cli/aeon/client.go
Outdated
| @@ -64,7 +64,6 @@ func getTlsConfig(args cmd.Ssl) (*tls.Config, error) { | |||
| } | |||
| } | |||
| // Else if RootCAs is nil, TLS uses the host's root CA set. | |||
|
|
|||
There was a problem hiding this comment.
Please, revert the change.
cli/aeon/cmd/uri.go
Outdated
| Key string | ||
| // Instance is an instance name. | ||
| Instance string | ||
| // Username is a user name for authorization |
There was a problem hiding this comment.
Suggested change
| // Username is a user name for authorization | |
| // Username is a user name for authorization. |
cli/aeon/cmd/uri.go
Outdated
| Instance string | ||
| // Username is a user name for authorization | ||
| Username string | ||
| // Password is a password for authorization |
There was a problem hiding this comment.
Suggested change
| // Password is a password for authorization | |
| // Password is a password for authorization. |
AlexandrLitkevich
force-pushed
the
TNTP-1074
branch
from
fdacd23 to
273b31a
Compare
@TarantoolBot document Title: add connection from the etcd/tcs config Added ability to connect to gRPC server used a configuration etcd/tcs tt aeon connect URI INSTANCE_NAME Closes #1052
AlexandrLitkevich
force-pushed
the
TNTP-1074
branch
from
273b31a to
51ccba3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aeon: add connection from the etcd/tcs
@@@@Tarantool_box document
Title: add connection from the etcd/tcs config
Added ability to connect to gRpc server used a configuration etcd/tcs
tt aeon connect URI INSTANCE_NAME
Closes #1052