msgpack: Add 1.0.0 version support #167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since msgpack 1.0.0 was released Unpacker does not have strict_map_key param and it is True by default now. It makes the Connector fail with an error: `ValueError: int is not allowed for map key` To solve this issue the __init__ method of the Response object was refactored and the strict_map_key param is added for versions less than 1.0.0 Fixes #155
artembo
force-pushed
the
artembo/gh-155-msgpack-fix
branch
from
fa34c9f to
4fe621e
Compare
Merged
|
Closed in favor of PR #173. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for msgpack version 1.0.0 where
strict_map_keyparam was removed.Please see #155 issue for details.
Since msgpack 1.0.0 was released Unpacker does not have strict_map_key param
and it is True by default now.
It makes the Connector fail with an error:
ValueError: int is not allowed for map keyThe PR contains a fix suggested by @Totktonada here in the PR #156 which is stuck.
Close related PR #156 please when this one is merged in master.