Fix polyfill in combination with unused CSS variable removal #17555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
force-pushed
the
fix/color-mix-var-removal
branch
from
352e77f to
b93750a
Compare
philipp-spiess
commented
Apr 6, 2025
I believe we used to use `Extract<AstNode, { nodes: AstNode[] }>` to get
all the AstNodes with children. But now that we are also taking its
`'nodes'`, we can simplify this:
```diff
- Extract<AstNode, { nodes: AstNode[] }>['nodes']
- AstNode[]
```
RobinMalfait
approved these changes
Apr 7, 2025
|
@philipp-spiess, do we have any approximate date for shipping this change (v4.1.4)? Our codebase is affected by this bug resulting in a number of missing color variables, and so we can't migrate to Tailwind v4.1+ until it's rectified. Thanks in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue we noticed while investigating #17553, where the unused CSS variable removal didn't work properly when the theme variable it tried to remove was modified by a polyfill rule.
The way the bookkeeping for the unused CSS variable worked was that it tired to find the declaration inside it's parent after the traversal. However, the
color-mix(…)polyfill has since then made changes to the declaration so it can't find it's position correctly anymore and will thus instead delete the last declaration of the node (this caused unrelated CSS variables to be eliminated while the ones withcolor-mix(…)were unexpectedly kept).To fix this, we decided to apply the polyfills after any eventual deletions. This also ensures that no
@supportsquery for the variables are created and simplifies the code a bit since all polyfills are now colocated.Test plan