Add test coverage for property-specific colors #17436
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
21304
to
21307
| .shadow-blue-500 { | ||
| --tw-shadow: #3b82f6; | ||
| box-shadow: var(--tw-inset-shadow), var(--tw-inset-ring-shadow), var(--tw-ring-offset-shadow), var(--tw-ring-shadow), var(--tw-shadow); | ||
| } |
There was a problem hiding this comment.
This seems wrong, this ins setting the shadow property and not the shadow-color here. Looks like you want to define this as --box-shadow-color-blue-500.
There was a problem hiding this comment.
You're right, good eye. This was a typo and incorrect assertion. Fixed!
There was a problem hiding this comment.
Interesting, now my tests are passing locally, but are failing on CI 🤔
Nevermind, I forgot to pull main 😅
It looks like a browser support features was added that impacted my assertions
There was a problem hiding this comment.
@philipp-spiess Can we merge this? Keeping it out of conflict with the snapshot files is not so fun 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several property-specific color variables available to maintain compatibility with v3. My team and I would like to use them, but would feel more comfortable if they were formally supported by v4. This PR adds test coverage for those features.
@RobinMalfait has confirmed that these features are not intended to be removed, see conversation here →
@crswll Has opened a PR here for the related documentation