Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript 5.5.4 → 5.6.3 (minor) #14680

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Oct 15, 2024

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ typescript (5.5.4 → 5.6.3) · Repo

Release Notes

5.6.3

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

5.6.2

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Oct 15, 2024
@depfu depfu bot force-pushed the depfu/update/pnpm/typescript-5.6.3 branch from d89b46c to f5f8eeb Compare October 16, 2024 11:25
@depfu depfu bot force-pushed the depfu/update/pnpm/typescript-5.6.3 branch from f5f8eeb to d20e021 Compare October 16, 2024 14:51
@philipp-spiess philipp-spiess requested a review from a team as a code owner October 18, 2024 13:03
Copy link
Contributor Author

depfu bot commented Oct 18, 2024

Sorry, but the merge failed with:

At least 1 approving review is required by reviewers with write access.

@@ -8,7 +8,6 @@

"moduleResolution": "Bundler",
"allowImportingTsExtensions": true,
"verbatimModuleSyntax": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.typescriptlang.org/tsconfig/#verbatimModuleSyntax

As far as I understand this, this option was not supposed to ever work and translate common JS files but we are using it like this right now in our .cts file. The docs suggest using a syntax like this instead:

import foo = require('foo');

export = {
  foo
}

We use the export = syntax already but changing the import accordingly breaks with another TS issue:

│ src/compat/colors.cts(1,1): error TS1202: Import assignment cannot be used when targeting EC
│ MAScript modules. Consider using 'import * as ns from "mod"', 'import {a} from "mod"', 'impo
│ rt d from "mod"', or another module format instead.

I don't know how to fix this other than removing verbatimModuleSyntax unfortunately 😞 cc @tailwindlabs/engineering

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @RobinMalfait @thecrypticace what are your thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant