-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update typescript 5.5.4 → 5.6.3 (minor) #14680
base: next
Are you sure you want to change the base?
Conversation
d89b46c
to
f5f8eeb
Compare
f5f8eeb
to
d20e021
Compare
Sorry, but the merge failed with:
|
@@ -8,7 +8,6 @@ | |||
|
|||
"moduleResolution": "Bundler", | |||
"allowImportingTsExtensions": true, | |||
"verbatimModuleSyntax": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://www.typescriptlang.org/tsconfig/#verbatimModuleSyntax
As far as I understand this, this option was not supposed to ever work and translate common JS files but we are using it like this right now in our .cts
file. The docs suggest using a syntax like this instead:
import foo = require('foo');
export = {
foo
}
We use the export =
syntax already but changing the import
accordingly breaks with another TS issue:
│ src/compat/colors.cts(1,1): error TS1202: Import assignment cannot be used when targeting EC
│ MAScript modules. Consider using 'import * as ns from "mod"', 'import {a} from "mod"', 'impo
│ rt d from "mod"', or another module format instead.
I don't know how to fix this other than removing verbatimModuleSyntax
unfortunately 😞 cc @tailwindlabs/engineering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @RobinMalfait @thecrypticace what are your thoughts?
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ typescript (5.5.4 → 5.6.3) · Repo
Release Notes
5.6.3
5.6.2
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by more commits than we can show here.
Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase
.All Depfu comment commands