feat: add empty response body support #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbRoehm
force-pushed
the
add-support-for-empty-response
branch
from
b767364 to
87c2e44
Compare
AlbRoehm
force-pushed
the
add-support-for-empty-response
branch
from
87c2e44 to
2e88a3d
Compare
tabilzad
approved these changes
Jan 26, 2025
| @@ -25,6 +25,7 @@ internal fun OpenApiSpec.serializeAndWriteTo(configuration: PluginConfiguration) | |||
| val sorted = new.copy( | |||
| components = new.components.copy( | |||
| schemas = new.components.schemas.toSortedMap() | |||
| .filter { (key, value) -> key != "kotlin.Nothing" } | |||
There was a problem hiding this comment.
Perhaps, instead of filtering at the sorting site, we could do it inside convertInternalToOpenSpec where other sanitization is already performed.
There was a problem hiding this comment.
Oh yes definitely a better place to put it there. I guess that was just the first option that "worked"...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the the
Nothingtype in a@KtorResponds([ResponseEntry("204", Nothing::class)])annotation a empty response body will be created in the openapi spec.It looked pretty straight forward so i gave it a try ... it's kinda late so i might have overlooked some stuff :)