fix: build on darwin #4527
Open
fix: build on darwin #4527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyim
commented
Apr 25, 2024
shyim
commented
Apr 25, 2024
shyim
commented
Apr 25, 2024
shyim
commented
Apr 25, 2024
|
Automated message: PR pending admin approval for build testing |
shyim
commented
Apr 25, 2024
shyim
commented
Apr 25, 2024
shyim
commented
Apr 25, 2024
shyim
force-pushed
the
fix-darwin
branch
10 times, most recently
from
d5fa87c
to
d28c7c1
Compare
|
Add to whitelist |
|
@shyim . Thank you for the PR. |
|
@renecannao it works without problems for me locally, had no crashes so far. |
|
Hi @shyim . |
|
M1 Pro |
Signed-off-by: Soner Sayakci <[email protected]>
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See here for successful darwin github pipeline https://github.com/shyim/proxysql/actions/runs/8837874315/job/24267718022 :)