Add 3 new status variables related to SET statements #4172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add status variables: * Com_backend_set_stmt - SET statements crafted and sent by ProxySQL. * Com_frontend_set_stmt - SET statements received by ProxySQL. * Com_frontend_failed_set_stmt - SET statements received by ProxySQL and failed to parse.
Test correct behaviour of backend_set_stmt, frontend_set_stmt and frontend_failed_set_stmt status variables.
Future patches make ProxysSQL set by default MySQL variables, therefore ProxySQL send SET statements on new connections that interfere with the expected number of queries in the test_binlog_reader_t.
Use the difference between the number of SET statements before and after the test queries. Otherwise, other tests in the CI may increase the counters and make the test fail.
To avoid interference from extra SET statements during the test, disable session tracking.
|
retest this please |
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add status variables: