[2.x] feat(migr): bump codebase to make compatible with sylius 2 and symfony 7 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
maxperei
commented
Mar 14, 2025
maxperei
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | yes |
| Fixed issue | n/a |
| License | MIT |
…match sylius2 requirements and sf7 standards
maxperei
force-pushed
the
feat/compatibility-v2
branch
7 times, most recently
from
df2beae to
d5d899b
Compare
maxperei
force-pushed
the
feat/compatibility-v2
branch
2 times, most recently
from
c7d31cb to
791f53d
Compare
maxperei
force-pushed
the
feat/compatibility-v2
branch
4 times, most recently
from
6bb1b36 to
520cf13
Compare
maxperei
force-pushed
the
feat/compatibility-v2
branch
from
520cf13 to
ed96219
Compare
maxperei
force-pushed
the
feat/compatibility-v2
branch
from
ed96219 to
ebc3028
Compare
oallain
reviewed
Mar 22, 2025
| @@ -19,7 +19,8 @@ jobs: | |||
| - 8.2 | |||
| - 8.3 | |||
| symfony: | |||
| - '6.4.*' | |||
There was a problem hiding this comment.
Sylius v2 is still compatible with Symfony 6.4, can't we keep it?
| symfony: | ||
| - 6.4 |
There was a problem hiding this comment.
Sylius v2 is still compatible with Symfony 6.4, can't we keep it?
| "sylius/sylius": "^1.12", | ||
| "symfony/framework-bundle": "^6.4", | ||
| "sylius/sylius": "~2.0.0", | ||
| "symfony/framework-bundle": "^6.4 || ^7.1", |
There was a problem hiding this comment.
This requirement is already in sylius/sylius, so we can remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.