Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return metadata in setup #37

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Return metadata in setup #37

merged 1 commit into from
Jan 31, 2024

Conversation

dabacon
Copy link
Contributor

@dabacon dabacon commented Jan 31, 2024

Since version 1.3 of sphinx, the setup can return a dictionary with meta data about the extension. The details of this metadata are https://www.sphinx-doc.org/en/master/extdev/index.html

This PR adds this metadata. Importantly this stops a warning from sphinx that the app does not return whether it is parallel (read/write) safe. My understanding of this app is that it is parallel safe for both, so returned True for both.

I rearranged the setting of __version__, but one could also import _version and use directly.

@asmeurer
Copy link
Member

Looks good. We'll have to do some clean up of the CI to release.

@asmeurer asmeurer merged commit f8bc715 into sympy:master Jan 31, 2024
0 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants