Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ErrorHandler] Improve an error message #59899

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Mar 3, 2025

Q A
Branch? 7.3
Bug fix? no
New feature? no
Deprecations? no
Issues n/a
License MIT

I got this error message this morning and I was confused.

@OskarStark
Copy link
Contributor

As a bugfix?

@mtarld
Copy link
Contributor

mtarld commented Mar 3, 2025

IMO, it should be a feature, if it's merged as a bug, people doing expectErrorMessage in their tests will have broken tests when upgrading.

@mtarld
Copy link
Contributor

mtarld commented Mar 3, 2025

Failures look related btw 🙂

@OskarStark
Copy link
Contributor

IMO, it should be a feature, if it's merged as a bug, people doing expectErrorMessage in their tests will have broken tests when upgrading.

AFAIK we don't give BC promise for exception messages

@mtarld
Copy link
Contributor

mtarld commented Mar 3, 2025

AFAIK we don't give BC promise for exception messages

Noted, thanks!

@fabpot fabpot force-pushed the undefined-function-better-error-message branch from a288967 to 126f556 Compare March 3, 2025 11:20
@fabpot fabpot merged commit 8b00851 into symfony:7.3 Mar 3, 2025
10 of 11 checks passed
@fabpot fabpot deleted the undefined-function-better-error-message branch March 3, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants