Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Add methods param doc for isCsrfTokenValid attribute #20811

Merged

Conversation

Oviglo
Copy link
Contributor

@Oviglo Oviglo commented Mar 24, 2025

Add new params for isCsrfTokenValid attribute

PR: symfony/symfony#60007
Issue: #20810

@Oviglo
Copy link
Contributor Author

Oviglo commented Mar 24, 2025

I set this PR in draft because I cannot build the doc locally:
Capture d'écran 2025-03-24 111309

@carsonbot carsonbot changed the title Add methods param doc for isCsrfTokenValid attribute [Security] Add methods param doc for isCsrfTokenValid attribute Mar 24, 2025
@Oviglo
Copy link
Contributor Author

Oviglo commented Mar 24, 2025

Thanks @OskarStark

@Oviglo Oviglo marked this pull request as ready for review March 24, 2025 13:20
@carsonbot carsonbot added this to the 7.3 milestone Mar 24, 2025
@javiereguiluz javiereguiluz force-pushed the feature/security-iscsrftokenvalid-methods branch from 5e496d1 to 6d7c87f Compare March 26, 2025 09:21
@javiereguiluz javiereguiluz merged commit a1d7e49 into symfony:7.3 Mar 26, 2025
3 checks passed
@javiereguiluz
Copy link
Member

Loïc, thanks and congrats on your first Symfony Docs contribution 🎉

Note that while merging we did some rewords: see 84634a2 I know it looks like we changed everything ... but we only reword it to match the style of the existing docs. The core of your original contribution remained, so thanks for it. We also added the versionadded directive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants