Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] Add ability for voters to explain their vote #20690

Open
wants to merge 4 commits into
base: 7.3
Choose a base branch
from
Open

[Security] Add ability for voters to explain their vote #20690

wants to merge 4 commits into from

Conversation

MrYamous
Copy link
Contributor

Fix #20658

@carsonbot carsonbot added this to the 7.3 milestone Feb 25, 2025
javiereguiluz
javiereguiluz requested changes Feb 26, 2025
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matthieu, this is a good start, but I think we should also display an example of using this feature to add an explanation in some of the voter examples.

94noni
94noni reviewed Feb 26, 2025
View reviewed changes
security/voters.rst
If you return ``true`` from ``supports()``, then this method is called. Your
job is to return ``true`` to allow access and ``false`` to deny access.
The ``$token`` can be used to find the current user object (if any). In this
example, all of the complex business logic is included to determine access.
The ``$token`` can be used to find the current user object (if any). The ``$vote``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps document were this can be seen? or retrieved to be displayed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure to understand your point here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant something like the workflow transition blocker message
is it possible to see this "vote message" somewhere and how ?

OskarStark
OskarStark reviewed Mar 10, 2025
View reviewed changes
OskarStark
OskarStark reviewed Mar 10, 2025
View reviewed changes
OskarStark
OskarStark reviewed Mar 10, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@94noni 94noni 94noni left review comments

@javiereguiluz javiereguiluz Awaiting requested review from javiereguiluz

Assignees
No one assigned
Labels
Security Status: Needs Review
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

[Security] Add ability for voters to explain their vote
5 participants
@MrYamous @javiereguiluz @OskarStark @94noni @carsonbot