Readd handling of fallback of bundles directory in Apache config #20619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/ Cheers! Carsonbot |
|
@freecastle thanks for this contribution and sorry it took us so long to merge it. I had some issues while trying to merge it (because the PR targeted the legacy 5.4 branch). So, I recreated the PR for 6.4 branch in #20849 and I'm closing this PR instead. I cherry-picked your original commits so you get full credit of your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 035af33 a configuration for Apache was removed that would prevent URLs in the public
bundlesdirectory to be parsed from Symfony. Unfortunately, my question in #17597 (comment) if there was any reason for removing this part didn't get any answers. The similar directive for Nginx is still there: https://github.com/symfony/symfony-docs/blob/5.4/setup/web_server_configuration.rst?plain=1#L123-L128, so I assume it was just a mistake and to not handle thebundlesdirectory not by Symfony is still a good idea.