-
-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add V2 of redjan/fcm-bundle #1747
base: main
Are you sure you want to change the base?
Conversation
redjanym
commented
Jan 27, 2025
Q | A |
---|---|
License | MIT |
Packagist | https://packagist.org/packages/redjanym/fcm-bundle |
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. redjanym/fcm-bundle1.1 vs 2.0diff --git a/redjanym/fcm-bundle/1.1/config/packages/redjan_ym_fcm.yaml b/redjanym/fcm-bundle/2.0/config/packages/redjan_ym_fcm.yaml
index 1d6e668a..ab12591a 100644
--- a/redjanym/fcm-bundle/1.1/config/packages/redjan_ym_fcm.yaml
+++ b/redjanym/fcm-bundle/2.0/config/packages/redjan_ym_fcm.yaml
@@ -1,2 +1,2 @@
redjan_ym_fcm:
- firebase_api_key: '%env(resolve:FCM_SERVER_KEY)%'
+ service_account_file: '%env(resolve:FCM_DEFAULT_SERVICE_ACCOUNT_FILE_PATH)%'
diff --git a/redjanym/fcm-bundle/1.1/manifest.json b/redjanym/fcm-bundle/2.0/manifest.json
index e712b9af..15564cff 100644
--- a/redjanym/fcm-bundle/1.1/manifest.json
+++ b/redjanym/fcm-bundle/2.0/manifest.json
@@ -6,6 +6,6 @@
"config/": "%CONFIG_DIR%/"
},
"env": {
- "FCM_SERVER_KEY": "YOUR_FIREBASE_CLOUD_MESSAGING_SERVER_KEY"
+ "FCM_DEFAULT_SERVICE_ACCOUNT_FILE_PATH": "YOUR_FCM_SERVICE_ACCOUNT_FILE_ABSOLUTE_PATH"
}
} |
Head branch was pushed to by a user without write access
@@ -0,0 +1,2 @@ | |||
redjan_ym_fcm: | |||
service_account_file: '%env(resolve:FCM_DEFAULT_SERVICE_ACCOUNT_FILE_PATH)%' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you don't call it a default
service account file in the bundle, env doesn't need it as well.
service_account_file: '%env(resolve:FCM_DEFAULT_SERVICE_ACCOUNT_FILE_PATH)%' | |
service_account_file: '%env(resolve:FCM_SERVICE_ACCOUNT_FILE_PATH)%' |
"config/": "%CONFIG_DIR%/" | ||
}, | ||
"env": { | ||
"FCM_DEFAULT_SERVICE_ACCOUNT_FILE_PATH": "YOUR_FCM_SERVICE_ACCOUNT_FILE_ABSOLUTE_PATH" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've assumed it's a json from https://github.com/redjanym/FCMBundle/wiki/Installation#step-3-configuration
"FCM_DEFAULT_SERVICE_ACCOUNT_FILE_PATH": "YOUR_FCM_SERVICE_ACCOUNT_FILE_ABSOLUTE_PATH" | |
"FCM_SERVICE_ACCOUNT_FILE_PATH": "%kernel.project_dir%/path/to/file.json" |