Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ch/add quarry ex #11

Merged
merged 25 commits into from
Sep 11, 2023
Merged

Ch/add quarry ex #11

merged 25 commits into from
Sep 11, 2023

Conversation

cleherny
Copy link
Contributor

@cleherny cleherny commented Aug 31, 2023

What

Addition of an example of career detection using the repo scripts.
The new example can be found in the \example\quarry-detection folder.

Comments

I encountered package compatibility issues in the ac/improve-code-quality branch that I did not encounter when testing the proj-dqry project with ac/add-set-up-tools. As a result, I have set the version of some packages to the previous version for which I used to run proj-dqry:

  • geopandas==0.11.1
  • numpy==1.23.3
  • pillow==9.5.0 (version 10.0.0 was initially installed with this problem: PIL.Image.LINEAR no longer exists facebookresearch/detectron2#5010)
  • scikit-learn==0.24.2 (which I actually forgot to add in the branch recently merged with ch/dev_tm, I'll fix it when I finalize this branch. I got slight changes to the final prediction depending on the package version, so for now I prefer to keep the version I used to provide results).
    Further investigations are needed to understand the compatibility issues with the first two packages.

To improve in the future

Include the CRS transformation of the Swiss DEM directly in the script filter_prediction.py

To Do

Run the example and check if everything looks good and running fine. Test if more recent packages of the libraries mentioned above are also causing errors on other machines.

@cleherny cleherny requested a review from acerioni August 31, 2023 17:14
@stdl-s-sonarqube

This comment has been minimized.

@stdl-s-sonarqube

This comment has been minimized.

@acerioni acerioni added this to the First tagged version (v1.0) milestone Sep 8, 2023
@acerioni
Copy link
Member

acerioni commented Sep 8, 2023

See #13

@stdl-s-sonarqube
Copy link

Passed

Analysis Details

1 Issue

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 1 Code Smell

Coverage and Duplications

  • Coverage No coverage information (0.00% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: swiss-territorial-data-lab_object-detector_AYZ4zWIzr7JdaaSXwexc

View in SonarQube

@cleherny
Copy link
Contributor Author

The branch is ready to be merged on ac/improve-code-quality.

@cleherny cleherny merged commit d762e87 into ac/improve-code-quality Sep 11, 2023
1 check passed
@cleherny cleherny deleted the ch/add_quarry_ex branch September 15, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants