-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ch/add quarry ex #11
Merged
Merged
Ch/add quarry ex #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
See #13 |
… tile reprojection
The branch is ready to be merged on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Addition of an example of career detection using the repo scripts.
The new example can be found in the \example\quarry-detection folder.
Comments
I encountered package compatibility issues in the
ac/improve-code-quality
branch that I did not encounter when testing theproj-dqry
project withac/add-set-up-tools
. As a result, I have set the version of some packages to the previous version for which I used to runproj-dqry
:PIL.Image.LINEAR
no longer exists facebookresearch/detectron2#5010)ch/dev_tm
, I'll fix it when I finalize this branch. I got slight changes to the final prediction depending on the package version, so for now I prefer to keep the version I used to provide results).Further investigations are needed to understand the compatibility issues with the first two packages.
To improve in the future
Include the CRS transformation of the Swiss DEM directly in the script
filter_prediction.py
To Do
Run the example and check if everything looks good and running fine. Test if more recent packages of the libraries mentioned above are also causing errors on other machines.