Include "clang" diagnostics from SourceKit-LSP #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-server-bot test this please |
award999
force-pushed
the
clang-diagnostics
branch
from
3af7f56
to
ae55f0a
Compare
|
@swift-server-bot test this please |
award999
force-pushed
the
clang-diagnostics
branch
2 times, most recently
from
243f0fc
to
42de497
Compare
* Include "clang" in the list of diagnostics sources * Fix regex to not include "[-<code>]" that compiler outputs for C/C++ diagnostics * Clean up the "(fix available)" SourceKit includes in clang messages so that merging works proper * Add new tests to watch for clang diagnostics Issue: swiftlang#1028
* Make sure we're getting diagnostics * Realized was an issue where "instanceof" does not work when the extension under test is using source under "dist/" but the tests use source under "out" so if test instantiated an object, instanceof may not work in the extension code
award999
force-pushed
the
clang-diagnostics
branch
from
42de497
to
98b459b
Compare
- fixed swiftlang#1028 - diagnostic sources other than "swiftc" all regarded as SourceKit
plemarquand
approved these changes
Sep 20, 2024
|
@AppAppWorks this will be in the next release, thanks for you contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1028