-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge updates from release/1.0 to the main branch #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put a check in-place to unset the global default toolchain if it is no longer installed Set the global default to the installed toolchain if it is not set Add full toolchain selection resolution to the update operation resolve update parameters Fix the use command and toolchain selection routine to consider a global default set to a toolchain that is not installed as no selection at all Add check for the physical presence of a toolchain to proxy so that it prevents circularity errors and provides an actionable message
Add test cases Control verbosity of uninstall operation on macOS and other platforms
// This is a simple upgrade from the 0.4.0-dev pre-release | ||
if var config, !overwrite && | ||
( | ||
config.version == SwiftlyVersion(major: 0, minor: 4, patch: 0, suffix: "dev") || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my only fear is we will forget to update this if statement upon some release 🤔
justice-adams-apple
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the main branch with the fixes. Establish a fresh version with upgrade path from the release made from the 1.0 branch.