Migrate code to use Swift Regex

[Kyle-Ye]

• Fix compile warnings
• Migrate part of regex code to use Swift Regex

Motivation:

Migrate part of regex code to use Swift Regex. (Safer and Easier)

We should also consider to deprecate the TSCBasic.RegEx

Modifications:

Migrate part of the regex code to use Swift Regex

Result:

Safer, Easier and less code if we use Swift Regex.

Requirement/Dependency:

Bump minimal supported OS version to macOS 13

When WWDC 2023 is over and macOS 14 is introduced, the bump may be easier to accept.

[MaxDesiatov]

Swift stdlib Regex APIs are supported starting with macOS 13.0, while SwiftPM needs to support macOS 12.0. I reckon this will need to wait until we can bump the macOS deployment version, for which I can't give an estimate right now I'm afraid.

[Kyle-Ye]

Swift stdlib Regex APIs are supported starting with macOS 13.0, while SwiftPM needs to support macOS 12.0. I reckon this will need to wait until we can bump the macOS deployment version, for which I can't give an estimate right now I'm afraid.

The last time we bump the macOS deployment is by #6138 .

Why SwiftPM needs to support macOS 12.0? (Due to CI machine is currently not full on macOS 13 or something else?)

And I'd like to know is there a clear vision what range of OS version we should support on? (Like most Swift Package will only maintain support for at most 3 version eg. Swift 5.6 5.7 5.8)

Currently SwiftPM supports macOS 12 and macOS 13. And I believe when (macOS 13)+1 is released, maybe we can consider to drop macOS 12 support.

[MaxDesiatov]

#6138 was merged very recently. I'm inclined to think that the next deployment target bump won't happen at least until new macOS is released and widely available (including CI), but I can't comment on future plans, versions, and schedules.

[compnerd]

Windows support for Regex is questionable. There is no Swift in Swift yet due to bugs with SILOptimizer. We need to ensure that this doesn't regress Windows.

[neonichu]

@Kyle-Ye Thanks, this is a good change, but we'll have to wait as Max and Saleem are saying. Would you prefer that we keep this as a draft until a later point or close it?

[Kyle-Ye]

I'll make this into draft and waiting for the blocking problem to be fixed.

[MaxDesiatov]

@Kyle-Ye would you mind resolving conflicts on this one? Thanks!

[Kyle-Ye]

Yeah. I see #7313 is finally merged. I'll update the PR later today.

[Kyle-Ye]

@swift-ci please test

[Kyle-Ye]

Windows support for Regex is questionable. There is no Swift in Swift yet due to bugs with SILOptimizer. We need to ensure that this doesn't regress Windows.

Would you mind sharing with us the latest status of Regex support on Windows? cc @compnerd

[Kyle-Ye]

@swift-ci please test

[MaxDesiatov]

@swift-ci test windows

[Kyle-Ye]

@swift-ci smoke test

[MaxDesiatov]

After this one is merged we'll have to follow up on swiftlang/swift-tools-support-core#467 too.

[compnerd]

Doug was splitting out the regex bits such that bootstrapping isn't required and only the swift-syntax bits are. This is untested, but I believe might be done? I would say that run with cross-repository testing with swiftlang/swift#71349 to get the tests to build and run. I believe that @bnbarham might try to make some time to help get this enabled by default.

[Kyle-Ye]

@swift-ci please test

[Kyle-Ye]

Doug was splitting out the regex bits such that bootstrapping isn't required and only the swift-syntax bits are. This is untested, but I believe might be done? I would say that run with cross-repository testing with swiftlang/swift#71349 to get the tests to build and run. I believe that @bnbarham might try to make some time to help get this enabled by default.

Is there any updates on this and will it block the PR here? @compnerd

[Kyle-Ye]

@swift-ci please test

[Kyle-Ye]

The only missing part is Netrc which has a RegexUtil enum to handle the regex logic. Since it is private, I think it's OK not to deal with it right now.

For this PR, let's focus on removing TSCBasic.RegEx only.

[compnerd]

Doug was splitting out the regex bits such that bootstrapping isn't required and only the swift-syntax bits are. This is untested, but I believe might be done? I would say that run with cross-repository testing with swiftlang/swift#71349 to get the tests to build and run. I believe that @bnbarham might try to make some time to help get this enabled by default.

Is there any updates on this and will it block the PR here? @compnerd

Sadly, I think it will. I am unable to switch to the early-swift-driver on Windows due to the multitude of pending changes. I suspect that we will need to wait until after WWDC to make progress here.

[Kyle-Ye]

@swift-ci please test windows

[Kyle-Ye]

@swift-ci plese test

[Kyle-Ye]

@swift-ci please test