Skip to content

WiX: rename the product identifier #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

WiX: rename the product identifier #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions platforms/Windows/sdk/win/sdk.wxs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<Package
Language="1033"
Manufacturer="!(loc.ManufacturerName)"
Name="!(loc.Sdk_ProductName_$(ProductArchitecture))"
Name="!(loc.Windows_Sdk_ProductName_$(ProductArchitecture))"
UpgradeCode="$(WindowsSDKUpgradeCode)"
Version="$(NonSemVerProductVersion)"
Scope="$(PackageScope)">
Expand Down Expand Up @@ -614,7 +614,7 @@
</ComponentGroup>

<!-- Features -->
<Feature Id="SDK" AllowAbsent="no" Title="!(loc.Sdk_ProductName_$(ProductArchitecture))">
<Feature Id="SDK" AllowAbsent="no" Title="!(loc.Windows_Sdk_ProductName_$(ProductArchitecture))">
<ComponentGroupRef Id="XCTest" />
<ComponentGroupRef Id="Testing" />
<ComponentGroupRef Id="SwiftRemoteMirror" />
Expand Down
6 changes: 3 additions & 3 deletions platforms/Windows/shared/swift.en-us.wxl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@
<String Id="Rtl_ProductName_arm64" Value="Swift Windows Runtime (ARM64)" />
<String Id="Rtl_ProductName_amd64" Value="Swift Windows Runtime (AMD64)" />
<String Id="Rtl_ProductName_x86" Value="Swift Windows Runtime (X86)" />
<String Id="Sdk_ProductName_arm64" Value="Swift Windows SDK (ARM64)" />
<String Id="Sdk_ProductName_amd64" Value="Swift Windows SDK (AMD64)" />
<String Id="Sdk_ProductName_x86" Value="Swift Windows SDK (X86)" />
<String Id="Utl_ProductName_arm64" Value="Swift Windows Utilities (ARM64)" />
<String Id="Utl_ProductName_amd64" Value="Swift Windows Utilities (AMD64)" />
<String Id="Utl_ProductName_x86" Value="Swift Windows Utilities (X86)" />
<String Id="Windows_Sdk_ProductName_arm64" Value="Swift Windows SDK (ARM64)" />
<String Id="Windows_Sdk_ProductName_amd64" Value="Swift Windows SDK (AMD64)" />
<String Id="Windows_Sdk_ProductName_x86" Value="Swift Windows SDK (X86)" />
<String Id="Android_Sdk_arm64" Value="Swift Android SDK (ARM64)" />
<String Id="Android_Sdk_amd64" Value="Swift Android SDK (AMD64)" />
<String Id="Android_Sdk_arm" Value="Swift Android SDK (ARM)" />
Expand Down