[ST-NNNN] Add ConditionTrait.evaluate() #2740
Open
+65
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
reviewed
Mar 17, 2025
grynspan
reviewed
Mar 17, 2025
stmontgomery
added
the
workgroup: needs development
grynspan
changed the title
grynspan
reviewed
Mar 20, 2025
Merged
2 tasks
stmontgomery
added a commit
to swiftlang/swift-testing
that referenced
this pull request
Mar 25, 2025
…1036) This removes a mechanism in the implementation of `ConditionTrait` for a condition closure to provide an "override" comment. ### Motivation: While reviewing a draft evolution proposal for `ConditionTrait` (swiftlang/swift-evolution#2740) I realized that we don't use this "comment override" mechanism anywhere in the testing library. I believe we did back when it was first added, but it's no longer used. Removing this would allow the public API being proposed above to be simplified: the `evaluate()` method could return `Bool` instead of a tuple. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
stmontgomery
added
workgroup: ready
grynspan
approved these changes
Mar 28, 2025
stmontgomery
approved these changes
Apr 7, 2025
|
Thank you @Uncommon. The Testing Workgroup met on 4/7/25 and agreed to begin a review for this proposal. I will be acting as the review manager and will start that process soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal document moved from swiftlang/swift-testing#909