Rewrite plutil for parity with all Darwin functionality #5172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
parkera
force-pushed
the
parkera/plutil_rewrite
branch
from
313c7fc to
641ab89
Compare
jmschonfeld
approved these changes
Feb 20, 2025
|
@swift-ci test |
6 similar comments
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
parkera
force-pushed
the
parkera/plutil_rewrite
branch
from
46b076d to
be1272f
Compare
|
@swift-ci test |
|
Looks like the |
|
The test was looking at stdout for that output, but I moved it to stderr - which seems more correct. Fixed up the test. |
|
@swift-ci test |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new implementation for
plutil, which achieves parity with Darwin by sharing the same implementation.This is in swift-corelibs-foundation instead of swift-foundation, for now, because it depends on the "raw" serialization classes
PropertyListSerializationandJSONSerialization, plus a few CoreFoundation-isms. I think those can probably be addressed in follow-ups, which would let us sink this down to the essentials package.