Fix the managing of the session dictionary when you have nested wrappers #10345
+115
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDevlieghere
approved these changes
Mar 27, 2025
|
@swift-ci please test |
|
The two failing checks lead nowhere. Let's try this again. |
|
@swift-ci please test macOS Windows |
|
@swift-ci please test |
|
One test failure is that the SBThread.stop_info_data was not found. I'll try regenerating the python bindings to see if that fixes that one. The other is a swift test failure that doesn't look related. |
…ers (llvm#132846) Since the inner wrapper call might have removed one of the entries from the global dict that the outer wrapper ALSO was going to delete, make sure that we check that the key is still in the global dict before trying to act on it. (cherry picked from commit 8704635)
jimingham
force-pushed
the
swiftlang-python-callbacks
branch
from
bb1370a to
91be248
Compare
|
I had made the original cherry-pick against stable/20240723 at a point when there was an unrelated failing test still in the branch. That was why I was getting the stop_reason_data not found issue. Rebasing the patch to a newer source base should fix that failure. |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From (llvm#132846)
Since the inner wrapper call might have removed one of the entries from the global dict that the outer wrapper ALSO was going to delete, make sure that we check that the key is still in the global dict before trying to act on it.
(cherry picked from commit 8704635)