Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 5.9.0 explicitly to avoid getting 5.9.1 #30

Closed
wants to merge 1 commit into from

Conversation

czechboy0
Copy link
Collaborator

Motivation

In Swift 5.9.1, there were some improvements to corelibs-foundation around Sendability, however we need to keep supporting 5.9.0 toolchains.

One thing I learned today is that if you specify "5.9" from the docker registry, you might get "5.9.1", which we explicitly don't want, as we could miss issues that only show up on "5.9.0".

One option would be to have two pipelines, one for 5.9.0 and 5.9.1, however I don't think it's necessary, as we already have a 5.10 pipeline, verifying that newer toolchains work.

This PR bumps down the 5.9 pipeline explicitly to use 5.9.0.

Modifications

Explicitly require 5.9.0, instead of using the latest 5.9 toolchain.

Result

More issues are caught in CI instead of only hitting users who use 5.9.0 later.

Test Plan

Ran locally, still passes.

@czechboy0 czechboy0 closed this Nov 30, 2023
@czechboy0 czechboy0 deleted the hd-59-use-590 branch November 30, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant