Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] : Remove deprecated options on unit-test action #510

Merged
merged 6 commits into from
Mar 20, 2025
Merged

[ci] : Remove deprecated options on unit-test action #510

merged 6 commits into from
Mar 20, 2025

Conversation

sebsto
Copy link
Contributor

@sebsto sebsto commented Mar 18, 2025 •
edited
Loading

Attempt to fix CI

Remove usage of deprecated parameters on unit-test.

  • explicitly enable tests on nightly 6.0
  • explicitly enable tests on nightly next
  • explicitly enable tests on nightly main

At the time of this writing, this resolves to

linux_6_0_container_image="swift:6.0-jammy"
linux_nightly_next_container_image="swiftlang/swift:nightly-6.1-jammy"
linux_nightly_main_container_image="swiftlang/swift:nightly-main-jammy"

@sebsto sebsto added the 🔨 semver/patch No public API change. label Mar 18, 2025
@sebsto sebsto self-assigned this Mar 18, 2025
@sebsto sebsto added this to the 2.0 milestone Mar 18, 2025
@sebsto sebsto requested review from FranzBusch and fabianfett March 18, 2025 17:18
@sebsto sebsto mentioned this pull request Mar 18, 2025
Open
@sebsto
Copy link
Contributor Author

sebsto commented Mar 18, 2025 •
edited
Loading

This should address #509

@sebsto sebsto changed the title [fix 509] : Remove test on nightly-main [ci] : fix 509 - Remove test on nightly-main Mar 18, 2025
@sebsto sebsto changed the title [ci] : fix 509 - Remove test on nightly-main [ci] : fix 509 - Disable unit tests on nightly-main Mar 18, 2025
fabianfett
fabianfett requested changes Mar 19, 2025
View reviewed changes
Copy link
Member

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not disable nightly-main if it fails.

@sebsto
Copy link
Contributor Author

sebsto commented Mar 19, 2025

@fabianfett OK. I keep this PR open because I removed the deprecated properties.

The last commit re-enabled linux_nightly_main_enabled

@sebsto
Copy link
Contributor Author

sebsto commented Mar 19, 2025

crash is reported on Swiftlang project
swiftlang/swift#80115 (comment)

@sebsto sebsto requested a review from fabianfett March 19, 2025 17:34
@fabianfett
Copy link
Member

Please rename PR then :)

@sebsto sebsto changed the title [ci] : fix 509 - Disable unit tests on nightly-main [ci] : fix 509 - removed deprecated option on unit-test action Mar 19, 2025
@sebsto sebsto requested a review from fabianfett March 19, 2025 18:28
@sebsto sebsto changed the title [ci] : fix 509 - removed deprecated option on unit-test action [ci] : Removed deprecated options on unit-test action Mar 19, 2025
@sebsto sebsto changed the title [ci] : Removed deprecated options on unit-test action [ci] : Remove deprecated options on unit-test action Mar 19, 2025
@fabianfett fabianfett added semver/none No version bump required. and removed 🔨 semver/patch No public API change. labels Mar 20, 2025
@sebsto sebsto merged commit 8939095 into swift-server:main Mar 20, 2025
30 of 31 checks passed
@sebsto sebsto deleted the sebsto/fix_ci_509 branch March 20, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianfett fabianfett fabianfett approved these changes

@FranzBusch FranzBusch Awaiting requested review from FranzBusch

Assignees

@sebsto sebsto

Labels
semver/none No version bump required.
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sebsto @fabianfett