Update LambdaContext #345
Merged
Update LambdaContext #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As outlined in the v2 API proposal (#339), the
eventLoopandallocatorproperties are to be removed fromLambdaContext. ThedetachedBackgroundTask(_:)function and the associatedtasksproperty are also not needed since the v2 API will introduce handlers that support background task execution through a writer passed to the handler.Modifications:
Introduced
NewLambdaContext: exactly the same asLambdaContextbut without theeventLoop,allocator, andtasksproperties, and thedetachedBackgroundTask(_:)function.LambdaContextwas not modified directly in order to keep the current functionality untouched.Result:
NewLambdaContextcan be used to continue implementing the new API.