Update async usages in README and examples to shutdown properly #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: In several examples of async/await support, the call to shutdown() on the HTTPClient are made with await but do not call get() on the EventLoopFuture. Modifications: Add the .get() call in four locations that need it. Result: After fixing this, the client should properly get closed down and there are no longer warnings emitted by the compiler.
FranzBusch
approved these changes
Jan 23, 2024
|
@swift-server-bot test this please |
dnadoba
requested changes
Jan 23, 2024
There was a problem hiding this comment.
There is a shutdown() that is async and needs to be awaited. I'm not sure why you are seeing warnings. Can you please post the exact warning you are seeing? Do you have a reproducer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In several examples of async/await support, the call to shutdown() on the HTTPClient are made with await but do not call get() on the EventLoopFuture.
Modifications:
Add the .get() call in four locations that need it.
Result:
After fixing this, the client should properly get closed down and there are no longer warnings emitted by the compiler.