Tentative Vitest #2711
Open
Tentative Vitest #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't fully understand the skip thing - I don't have any opinion on how you wanna approach this, the end result of using Vitest instead of Mocha to run the tests (without adjusting any of the tests, ideally) is what counts. |
|
Forget about the skip thing 😅 Here is what I have locally atm: The |
|
Thank you for tackling this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have #2706 we probably need to go to
vitestand manage wellESM.Also linked with this issue: #2031
Just started small to see if it's the good direction.
svelte2tsx test script is calling
mocha&vitestand when tests are ok in vitest, Iskipthem in mocha.So that the diff is approachable.
What do you think ?