Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose matched route #13635

Closed
wants to merge 1 commit into from
Closed

feat: expose matched route #13635

wants to merge 1 commit into from

Conversation

Rich-Harris
Copy link
Member

This is impromptu hackathon output and shouldn't be merged in its current state — it's here for mostly illustrative purposes.

For apps deployed to Vercel (and many other platforms) a SvelteKit app typically gets bundled into a single serverless function. For observability this is suboptimal since you can't group logs by route, only by path. We can fix this by exposing the matched route from SvelteKit (via a header like x-sveltekit-matched-route), and then forwarding that to the deployment platform (theoretically on Vercel via something like x-matched-route, though this isn't currently implemented on the Vercel side.

cc @tobiaslins


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Mar 24, 2025

⚠️ No Changeset found

Latest commit: 22c9ed2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot
Copy link

@Rich-Harris
Copy link
Member Author

Merged #13679 which satisfies the motivating use case; we can revisit this in future if necessary

@Rich-Harris Rich-Harris closed this Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant