-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deprecate adapter-cloudflare-workers
in favour of adapter-cloudflare
#13634
Conversation
🦋 Changeset detectedLatest commit: 49d28e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Ben McCann <[email protected]>
Co-authored-by: Ben McCann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! I love seeing a single adapter that chooses workers or pages for you based on the config file! 🫶
documentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated
Show resolved
Hide resolved
documentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Ben McCann <[email protected]>
Thanks for the feedback guys. I've updated the docs and also bumped the minimum Wrangler version to v4. I've also updated the fallback option to work with Cloudflare Workers if the user has configured the assets 404-handling option. EDIT: I've also added some simple tests to check that the build output is successful and works with the pages/workers dev environment provided by wrangler. |
an alternative that closes #13427
closes #13360
closes #13071
closes #13005
closes #12813
closes #13579
closes #10924
This PR adds a deprecation notice to the
adapter-cloudflare-workers
docs while adding support for Cloudflare Workers Static Assets by skipping Cloudflare Pages-specific build steps and respecting Wrangler configuration settings if building for Cloudflare Workers Static Assets.We use a heuristic to guess whether we're building for Cloudflare Pages or Workers based on the Wrangler configuration file settings, but even if there is no Wrangler configuration file, the build output is compatible with both platforms.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits