-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: service worker base path in dev mode #12577
base: main
Are you sure you want to change the base?
fix: service worker base path in dev mode #12577
Conversation
🦋 Changeset detectedLatest commit: 28294e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks for the PR! Is this test suite a good fit for your test?
|
Hey, thank you for the review. Saw it a bit late :-) will go through it 👍🏻 |
The tests are skipped in dev mode 👍🏻 let me just add relevant test cases there 💪🏻 |
@eltigerchino added the tests and your comment 👍🏻 |
Thank you! I'll wait for another review before merging just to sanity check this. |
Using a service worker in dev mode was not respecting the configured base path and it was missing from the filesystem import.
This PR prepends the base path before the filesystem import.
In a case with the basepath of
/console
,http://localhost:3000/console/service-worker.js
will resolve now to:I didn't find a good place to add a test though. I could add another
packages/kit/test/apps/dev-only
test suite with a base path, but I'd rather wait on some feedback if this is the right choice 👍🏻Created a PoC of what the tests could look like => TorstenDittmann/kit@fix-service-worker-base-path...fix-service-worker-base-path-tests
More context to this issue can be found here => #12039
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits